Fix primitive boolean @RequestParam handling and invalid value behavior #36068
+87
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Spring MVC request parameter binding for primitive boolean
types in two edge cases:
@RequestParam booleannow consistentlyresult in
MethodArgumentTypeMismatchException, leading to HTTP 400.@RequestParam(required = false)now default tofalseinstead ofraising a type mismatch exception.
Motivation
Previously:
required=falsewould still raiseTypeMismatchExceptionwhen missing, despite being optional.This behavior was surprising and inconsistent with developer expectations.
Changes
AbstractNamedValueMethodArgumentResolverto correctly handlemissing primitive boolean parameters when
required=false.RequestMappingHandlerAdapterTests.Impact